Skip to content

fixed broken link and broken image #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

fixed broken link and broken image #5241

merged 1 commit into from
Nov 1, 2024

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Oct 30, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the project-showcase-constants.ts file by modifying links and images for specific projects within the showcase data.

Detailed summary

  • Updated link for the project from @goatgamingbot to https://goatgaming.com/.
  • Changed image for the storychain project from ipfs://Qmau1mgrzahdfEtJFU9i2pSKMM7AwHav6tQCVEdJARUFpb to ipfs://QmUUBdNHa7ZoiRQicNathMY6G8GTBA4S9cRY1RRBXAKpYi.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ccbf2d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 7:24pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 1, 2024 7:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 1, 2024 7:24pm
wallet-ui ⬜️ Skipped (Inspect) Nov 1, 2024 7:24pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 30, 2024
@codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (baf2198) to head (ccbf2d2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5241   +/-   ##
=======================================
  Coverage   45.37%   45.37%           
=======================================
  Files        1067     1067           
  Lines       55446    55446           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29598    29598           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from baf2198
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 1.9 s (-45.72% 🔽) 2.7 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 5.4 s (-6.18% 🔽) 7.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 167 ms (+5.79% 🔺) 263 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 44 ms (-37.61% 🔽) 54 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 540 ms (+94.09% 🔺) 880 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 1, 2024
@gregfromstl Graphite App
Copy link
Contributor

gregfromstl commented Nov 1, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 1, 2:33 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 1, 2:33 PM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 3:24 PM EDT: A user merged this pull request with the Graphite merge queue.

@saminacodes
fixed broken link and broken image (#5241)
ccbf2d2 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `link` and `image` properties for specific projects in the `PROJECT_SHOWCASE_DATA` array within the `project-showcase-constants.ts` file.

### Detailed summary
- Updated `link` for the gaming project from `@goatgamingbot` to `https://goatgaming.com/`.
- Changed `image` for the `storychain` project from `ipfs://Qmau1mgrzahdfEtJFU9i2pSKMM7AwHav6tQCVEdJARUFpb` to `ipfs://QmUUBdNHa7ZoiRQicNathMY6G8GTBA4S9cRY1RRBXAKpYi`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the project-showcase-fixes branch from 8b4f136 to ccbf2d2 Compare November 1, 2024 19:12
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 19:12 Inactive
@graphite-app graphite-app bot merged commit ccbf2d2 into main Nov 1, 2024
31 checks passed
@graphite-app graphite-app bot deleted the project-showcase-fixes branch November 1, 2024 19:24
@vercel vercel bot temporarily deployed to Production – docs-v2 November 1, 2024 19:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 1, 2024 19:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 1, 2024 19:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls jnsdls approved these changes

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saminacodes @gregfromstl @joaquim-verges @jnsdls